Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate the assets of data store and source to Polypheny-DB #90

Closed
wants to merge 1 commit into from

Conversation

malikrafsan
Copy link

@malikrafsan malikrafsan commented Apr 4, 2024

Summary

In this pull request, we move the logos from stored at the Frontend (Polypheny-UI) to the Backend (Polypheny-DB). We also add the logo path/icon identifier on the response regarding Data Store and Data Source (/getSnapshot). By doing this, we can simplify the process of adding new Data Stores / Data Sources by storing the logos in Polypheny-DB sources together with the adapter implementation.

Fixes: #222

Changes

  • Add adapterLogo attribute on AdapterProperties annotation interface
  • Send adapterLogo attribute with existing adapter information
  • Change Polypheny-UI logic regarding adapterLogo

Related PRs


Screenshots

  • Asset files can be served by Polypheny-DB, under /public hosted path
    Screenshot from 2024-04-05 00-59-49

  • Polypheny-UI can access the Polypheny-DB static files and the Data Source and Data Store logos are shown successfully
    Screenshot from 2024-04-05 01-02-00

@malikrafsan malikrafsan changed the title feat: migrate the assets of data store and source to polypheny db Migrate the assets of data store and source to Polypheny-DB Apr 4, 2024
@malikrafsan malikrafsan marked this pull request as ready for review April 4, 2024 18:08
@hennlo hennlo requested review from datomo and vogti April 5, 2024 12:40
@vogti vogti deleted the branch polypheny:refactor April 8, 2024 15:11
@vogti vogti closed this Apr 8, 2024
@malikrafsan
Copy link
Author

Hi @vogti , firstly, thank you so much for your review! Is there any reason why you close this PR? Is it because of the polypheny:refactor branch has been merged and deleted? If so, I will change the target branch to be polypheny:master branch. Once again, thank you so much!

@vogti
Copy link
Member

vogti commented Apr 9, 2024

Hi @malikrafsan Sorry, the PR has automatically been closed because I merged the refactor branch. Please open the PR / change the target branch to master. Thank you for the PR, and sorry for the confusion. I did not realize that the PR has been closed.

@malikrafsan
Copy link
Author

Hi @vogti

No worries, no problem at all! I'll reopen the PR and adjust the target to the master branch. Looking forward to getting your feedback on the PR. Thank you so much!!

@malikrafsan
Copy link
Author

it seems like I cannot change the target branch and reopen this PR. Therefore, I open a new PR for this, which can be accessed on here. Please let me know if you have any concern! Thank you!

#93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants