Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various improvements to the Docker configuration #94

Merged
merged 5 commits into from
Apr 18, 2024
Merged

Various improvements to the Docker configuration #94

merged 5 commits into from
Apr 18, 2024

Conversation

gartens
Copy link
Contributor

@gartens gartens commented Apr 12, 2024

Summary

Various improvements to the Docker pages, such as:

  • Collapsing dockeredit and dockernew component into a single dockerinstance component
  • Current and past handshakes are now listed. This way running handshakes can be resumed even when e.g. the browser window is closed.
  • Type the results of the calls in the crud service
  • Adapt to changes on the Polypheny side (See #489)

@gartens gartens mentioned this pull request Apr 12, 2024
Merged
datomo
datomo reviewed Apr 14, 2024
View reviewed changes
Copy link
Member

@datomo datomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you @gartens.

src/app/components/docker/dockerhandshake/dockerhandshake.component.html Outdated Show resolved Hide resolved
src/app/views/dockerconfig/dockerconfig.component.ts Outdated Show resolved Hide resolved
@vogti vogti merged commit a74a97e into master Apr 18, 2024
6 checks passed
@vogti vogti deleted the docker-improvements branch April 18, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datomo datomo datomo left review comments

@vogti vogti vogti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gartens @vogti @datomo