-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bindings init #4
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add ci/cd
fix: workflows
dOrgJelli
approved these changes
Jun 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I left some small comments and few improvements that came to my mind! Some of those can be done in subsequent PR. I agree that rust crates for common functions and utility can be nice to have to improve readability of the repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Includes:
The
wrap/rust
bindings will come in a future PR. See #5Closes polywrap/kotlin-client#31
Notes
The
wrap-assemblyscript
bindings have a spacing/indentation issue that I'm fairly sure is an artifact of thehandlebars
package. The spacing becomes distorted when partials reference other partials.The
plugin-kotlin
bindings use a serialized version of the wrap manifest in order to avoid adding a JSON dependency to the Kotlin client. The manifest bytes output from the wrapper bindings do not match the expected CLI output. MessagePack serialization output can vary depending on the configuration of the MessagePack library used, so this is not necessarily an issue. For example, some libraries can code an i32 as an i16 to save space. The manifest bytes in the bindings are fine so long as the Rust client's MessagePack serialization package follows the MessagePack standard.