Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bindings init #4

Merged
merged 41 commits into from
Jun 29, 2023
Merged

bindings init #4

merged 41 commits into from
Jun 29, 2023

Conversation

krisbitney
Copy link
Contributor

@krisbitney krisbitney commented Jun 28, 2023

TODO:

  • Add CD that pushes build artifacts to github

Includes:

  • app-typescript
  • plugin-typescript
  • plugin-rust
  • plugin-python
  • plugin-kotlin
  • wrap-assemblyscript
  • wrap-rust

The wrap/rust bindings will come in a future PR. See #5

Closes polywrap/kotlin-client#31

Notes

The wrap-assemblyscript bindings have a spacing/indentation issue that I'm fairly sure is an artifact of the handlebars package. The spacing becomes distorted when partials reference other partials.

The plugin-kotlin bindings use a serialized version of the wrap manifest in order to avoid adding a JSON dependency to the Kotlin client. The manifest bytes output from the wrapper bindings do not match the expected CLI output. MessagePack serialization output can vary depending on the configuration of the MessagePack library used, so this is not necessarily an issue. For example, some libraries can code an i32 as an i16 to save space. The manifest bytes in the bindings are fine so long as the Rust client's MessagePack serialization package follows the MessagePack standard.

krisbitney and others added 30 commits June 14, 2023 16:08
@krisbitney krisbitney mentioned this pull request Jun 28, 2023
9 tasks
Copy link
Contributor

@Niraj-Kamdar Niraj-Kamdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I left some small comments and few improvements that came to my mind! Some of those can be done in subsequent PR. I agree that rust crates for common functions and utility can be nice to have to improve readability of the repo.

.github/workflows/cd.yaml Show resolved Hide resolved
.github/workflows/cd.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Show resolved Hide resolved
@krisbitney krisbitney merged commit 4c91a1a into dev Jun 29, 2023
@dOrgJelli dOrgJelli deleted the kris/wrap-0.1 branch July 18, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kotlin Client Plugin Bindings
3 participants