Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Refactor for Final Release #28

Merged
merged 129 commits into from
Jul 11, 2024
Merged

Code Refactor for Final Release #28

merged 129 commits into from
Jul 11, 2024

Conversation

pomonam
Copy link
Owner

@pomonam pomonam commented Jul 11, 2024

This PR implements a comprehensive code refactoring to prepare for its final release. The changes focus on improving code quality, performance, and maintainability.

  • Improved code readability and structure
  • Optimized performance and memory usage
  • Updated all example files to reflect recent changes
  • Revised documentation to accurately represent the current codebase
  • Expanded pytest coverage to ensure code correctness (now, we have the identical set of tests with the internal implementation)

Some TODOs:

  • Enhance AMP (Automatic Mixed Precision) logic.
  • Implement regression tests to verify consistency with the internal version

@pomonam
Copy link
Owner Author

pomonam commented Jul 11, 2024

Per token IF computation (#10) is also implemented.

@pomonam pomonam merged commit 52a67f9 into dev Jul 11, 2024
8 checks passed
@pomonam pomonam deleted the openwebtext branch July 11, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant