Fix issue 170 #181
Fix issue 170 #181
Conversation
This reverts commit 221553b.
|
The plugin doesn't need it. It has a warning that it requires an extension. |
| @@ -73,6 +73,7 @@ protected ICompilationUnit createCUfromTestFile(IPackageFragment pack, String cu | |||
| return unit; | |||
| } | |||
|
|
|||
| @SuppressWarnings("deprecation") | |||
There was a problem hiding this comment.
Which deprecated method is being used?
There was a problem hiding this comment.
The field AST.JLS8 is deprecated
| @@ -988,6 +989,7 @@ private void putIntoMethodToOps(HashMap<String, LinkedList<TypesOfMethodOperatio | |||
| /** | |||
| * Parse a Java file, and let visitor to visit declaring methods. | |||
| */ | |||
| @SuppressWarnings("deprecation") | |||
There was a problem hiding this comment.
What is the deprecated method?
There was a problem hiding this comment.
The field AST.JLS8 is deprecated
| @@ -147,6 +148,7 @@ private static File findEvaluationPropertiesFile(IJavaProject project, String fi | |||
| /** | |||
| * Create CompilationUnit from ICompilationUnit. | |||
| */ | |||
| @SuppressWarnings("deprecation") | |||
There was a problem hiding this comment.
The field AST.JLS8 is deprecated
There was a problem hiding this comment.
Then use the non-deprecated one rather than suppressing this warning. Thanks.
There was a problem hiding this comment.
I tried AST.JLS11, but it could fail building.
There was a problem hiding this comment.
Hm. Looks like the tests are failing with the newer Eclipse version.
There was a problem hiding this comment.
Is the warning caused by JDK version?
There was a problem hiding this comment.
OK, let's do this. Keep the warning suppression but change it https://help.eclipse.org/2018-09/topic/org.eclipse.jdt.doc.isv/reference/api/org/eclipse/jdt/core/dom/AST.html#JLS10.
edu.cuny.hunter.mylyngit.core/src/edu/cuny/hunter/mylyngit/core/utils/Vertex.java
Show resolved
Hide resolved
| @@ -147,6 +148,7 @@ private static File findEvaluationPropertiesFile(IJavaProject project, String fi | |||
| /** | |||
| * Create CompilationUnit from ICompilationUnit. | |||
| */ | |||
| @SuppressWarnings("deprecation") | |||
There was a problem hiding this comment.
This is the version of Eclipse the maven build is using: https://help.eclipse.org/2018-09/topic/org.eclipse.jdt.doc.isv/reference/api/org/eclipse/jdt/core/dom/AST.html#JLS10
#170