Fixed bug introduced in 39a6450

`EditorView.update()` replaces all props, so `dispatchTransaction` needs to be set every time props are updated.
ponymessenger · Aug 30, 2020 · 76877f8 · 76877f8
1 parent 7ba4dcb
commit 76877f8
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 8 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "use-prosemirror",
-    "version": "1.1.3",
+    "version": "1.1.4",
     "description": "ProseMirror for React",
     "main": "./dist/index.js",
     "types": "./dist/index.d.ts",

diff --git a/src/ProseMirror.tsx b/src/ProseMirror.tsx
@@ -31,14 +31,12 @@ export default forwardRef<Handle, Props>(function ProseMirror(
     const onChangeRef = useRef(onChange);
     onChangeRef.current = onChange;
     const viewRef = useRef<EditorView<any>>(null!);
-    viewRef.current?.update(props);
+    viewRef.current?.update(buildProps(props));
     useEffect(() => {
-        const view = new EditorView(root.current, {
-            ...initialProps.current,
-            dispatchTransaction: transaction => {
-                onChangeRef.current(view.state.apply(transaction));
-            },
-        });
+        const view = new EditorView(
+            root.current,
+            buildProps(initialProps.current),
+        );
         viewRef.current = view;
         return () => {
             view.destroy();
@@ -50,4 +48,14 @@ export default forwardRef<Handle, Props>(function ProseMirror(
         },
     }));
     return <div ref={root} style={style} className={className} />;
+    function buildProps(props: DirectEditorProps): DirectEditorProps {
+        return {
+            ...props,
+            dispatchTransaction: transaction => {
+                onChangeRef.current(
+                    viewRef.current.state.apply(transaction),
+                );
+            },
+        };
+    }
 });