Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update getNightBattleDDCIType for new CI and equipment #27

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sorewachigauyo
Copy link
Contributor

Tests done
Check that TPT setup works

{"data":{"shipId":566,"type":"DD","CI":"DD_T_P_T","lv":136,"rawLuck":26,"pos":0,"status":"yellow","items":[58,58,101,412],"improvement":[6,6,0,4],"searchLight":false,"flare":0,"defenseId":1501,"defenseTypeId":2,"ciType":13,"display":[58,58,412],"hitType":[1,1],"damage":[294,294],"damageTotal":588,"time":1622341680812}}

Check that TPT logs other CI

{"data":{"shipId":566,"type":"DD","CI":"DD_T_P_T","lv":136,"rawLuck":26,"pos":0,"status":"yellow","items":[58,58,101,412],"improvement":[6,6,0,4],"searchLight":false,"flare":-1,"defenseId":1501,"defenseTypeId":2,"ciType":3,"display":[58,58],"hitType":[1,1],"damage":[293,292],"damageTotal":585,"time":1622341814102}}

Check that TPD setup works

{"data":{"shipId":566,"type":"DD","CI":"DD_T_P_D","lv":136,"rawLuck":26,"pos":0,"status":"yellow","items":[58,75,101,412],"improvement":[6,0,0,4],"searchLight":false,"flare":0,"defenseId":1502,"defenseTypeId":2,"ciType":0,"display":[58],"hitType":[1],"damage":[177],"damageTotal":177,"time":1622341919020}}

Check that new personnel equipment works with existing DDCI

{"data":{"shipId":566,"type":"DD","CI":"DD_T_R_P","lv":136,"rawLuck":26,"pos":0,"status":"yellow","items":[58,307,101,412],"improvement":[6,0,0,4],"searchLight":false,"flare":-1,"defenseId":1505,"defenseTypeId":3,"ciType":8,"display":[58,307,412],"hitType":[1,-1,-1],"damage":[211,-1,-1],"damageTotal":211,"time":1622346462286}}

As an additional request, would it be possible to add more cases for night-battle-ci?
It would be nice to get more data by removing the normal map filter (could add a sortieMapId field to compensate) and also adding more paths such as api_req_battle_midnight/sp_midnight (battle starts from night, for maps like 5-3 where it would be easier to collect data)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant