Use new primary scanout output if old output is disabled #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`add_heads` will set it to `true` again, if used on the same `Output`. It doesn't like like cosmic-comp's usage of this does that currently though.
`Output` in Smithay doesn't track if the output still exists, other than based on whether or not it has strong references. Which doesn't seem to be working correctly. There may be leaked strong references to `Output`s somewhere, and maybe Smithay should track if an output is still valid, generally when it is exposed as a Wayland global (Smithay/smithay#1584). But a check like this works for now. Addresses #985.
This was referenced Nov 13, 2024
Drakulix
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Outputin Smithay doesn't track if the output still exists, other than based on whether or not it has strong references. Which doesn't seem to be working correctly.There may be leaked strong references to
Outputs somewhere, and maybe Smithay should track if an output is still valid, generally when it is exposed as a Wayland global(Smithay/smithay#1584). But a check like this works for now.
Addresses #985.