Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP cosmic-image-capture-source-unstable-v1 for workspace capture #47

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ids1024
Copy link
Member

@ids1024 ids1024 commented Jan 29, 2025

This will be needed to replace cosmic-screencopy-v2 with ext-image-copy-capture-v1.

This could also use ext-workspace-v1 handles, but we'll need to add that in cosmic-comp first. That could also be contributed upstream. Though on other compositors, workspaces may be on multiple monitors, so either this needs a an output argument again, or it will capture a single image for multiple outputs. (Or there could be a way to do both, if that's desired.)

@Drakulix
Copy link
Member

Drakulix commented Feb 4, 2025

I don't we have to transition everything at once, even though I would love to switch over to ext-workspace soon. But indeed it would be annoying to have to update this protocol so soon, if we want to use the ext-workspace handle either way. :/

@ids1024
Copy link
Member Author

ids1024 commented Feb 4, 2025

Yeah. And if we needed to support a capture source protocol for cosmic-workspace and one for ext-workspace in parallel for a while, that shouldn't be too bad. Given this is the simplest sort of protocol possible. That's more of a hassle with some other things.

But the other question is if we want to update our existing cosmic workspaces protocol to depend on ext workspace in the same way the toplevel protocol was updated in #29. That would mean not needing to replacing move_to_workspace and workspace_enter/workspace_leave with new requests/events. But workspace_enter/workspace_leave would become racy if they depend on cosmic handles created with a request rather than event (currently they're not, at least if the workspace global is bound first.)

If we want a completely new cosmic workspace extension protocol, it may be best not to add new requests to the existing one (as in #48). But maybe that's not particularly a problem either.

@Drakulix
Copy link
Member

Drakulix commented Feb 4, 2025

But the other question is if we want to update our existing cosmic workspaces protocol to depend on ext workspace in the same way the toplevel protocol was updated in #29.
...
If we want a completely new cosmic workspace extension protocol, it may be best not to add new requests to the existing one (as in #48).

Yeah I think it makes sense to ext-workspace as a base and add everything else we need in an extension protocol, rather than reworking it exactly as cosmic-toplevel works now. The latter was mostly done, because ext-toplevel-management isn't a thing yet, so we still need cosmic-toplevel for almost everything.

This is absolutely not the case with ext-workspace, where we really want to re-evaluate how to extend it, I feel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants