Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP workspace v2, based on ext-workspace #51

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

ids1024
Copy link
Member

@ids1024 ids1024 commented Feb 5, 2025

Needs cctk changes, and cosmic-comp support.

Updating the cctk abstraction handle both protocols may be a bit awkward. Perhaps like #46, it needs an enum wrapper over handles. Workspace.state could be changed to the ext type. While capabilities needs to be wrapped/split in some way.

This requires changes to the toplevel_info/toplevel_management protocols to use ext handles.

@Drakulix
Copy link
Member

Drakulix commented Feb 5, 2025

Since all our clients use cctk I think the way to proceed here is to change cosmic-comp to support both v1 and v2 as well as ext-workspace and then just transition clients over from v1 to v2 (making sure the cctk implementation works as well as it can, if only ext-workspace is available).

I don't think the clients need to handle the old version anymore, once we released cosmic-comp with v2 support.

@ids1024
Copy link
Member Author

ids1024 commented Feb 5, 2025

Yeah, that may be best here. Then it can just be updated similarly to #49 to require ext-workspace, and optionally the cosmic extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants