Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Workspace view closing by pressing current workspace or empty space #110

Closed
wants to merge 3 commits into from

Conversation

Adam-Cosner
Copy link
Contributor

This implements #49 by closing the workspace view when the current workspace is clicked or the empty space outside of the window views is clicked

@ids1024
Copy link
Member

ids1024 commented Jan 23, 2025

When updating a pull request you want to do a rebase rather than a merge. The merge also seems to have broken compiling, leaving a few includes of modules/types that don't exist.

But changing that, this seems to be working pretty well. I was uncertain if a mouse_area like this would intercept some mouse events that we want to go to child widgets, but I guess Iced handles this well.

@Adam-Cosner
Copy link
Contributor Author

Just fixed

@ids1024
Copy link
Member

ids1024 commented Jan 24, 2025

Rebased and merged manually as fd0bdee.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants