-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies and refactor mount operations #329
Conversation
This fixes the dreaded issue that is, the `loopdev` create is abandoned. TODO: Also needs some patching later.
This is required because of the new `home` crate versions, and `regex`.
@mmstick So we know what to do for testing this, does the Pop!_OS installer use this repo at all anymore, or does it only use https://github.com/pop-os/distinst-v2 now? If it no longer uses this, I guess we'd just check that the CLI still works? |
there's literally only one crate in distinst v2. I don't think it's finished at all. |
distinst-v2 is certainly being consumed by the Pop!_OS installer GUI. At the very least, its Debian package is a dependency of the installer: https://github.com/pop-os/installer/blob/f4d851490beac08ba8b6b371332a7e2de007e259/debian/control#L24 The v2 dbus service was integrated into the GUI installer back in 2021: pop-os/installer#237 It's quite possible the installer still relies on v1 in addition to v2 (looks like that's probably the case, or at least was at the time of that PR), which is why I wanted to check with Michael, who would know for sure. |
The distinst daemon was only partially completed. It was to be a gradual rewrite of the library as a service. Currently, it is only used for detecting refreshable operating systems. So the bulk of the installation is still carried out by the original distinst library. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Pop!_OS installer is still working with clean, refresh, and custom installs after these changes.
- Tested Intel custom install in virtual machine.
- Tested NVIDIA standard install from USB and refresh (initiated via Settings button in the OS) from Recovery partition on oryp7.
- Also tested a second refresh initiated via the installer in the Recovery partition.
This pull request updates the dependencies of the project and refactors the mount operations using the new Mount builder API from sys-mount. It also includes the update the sys-mount crate to version 3.0.1, which fixes the issue with the abandoned
loopdev
create.Additionally, the Cargo.lock file is updated and the toolchain version is changed to 1.70 to accommodate the new versions of the
home
crate andregex
.Fixes #318