Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Clone constraint on Flags #212

Closed
wants to merge 5 commits into from
Closed

Remove Clone constraint on Flags #212

wants to merge 5 commits into from

Conversation

wiiznokes
Copy link
Contributor

I don't see why we need this, Cosmic don't require it. And i need it for my app

@wiiznokes
Copy link
Contributor Author

oh, it looks like it's failing because of the Iced fork, I think it's safe to delete the Clone there too?
https://github.com/pop-os/iced/blob/94f8772b2f05195506f7a454e41290afe02eaa40/src/wayland/mod.rs#L34

@wiiznokes wiiznokes mentioned this pull request Nov 17, 2023
Merged
@wiiznokes
Copy link
Contributor Author

wiiznokes commented Dec 2, 2023 •
edited
Loading

Now that iced has been updated, i think this can be merge. I ran git rebase origin/master but i'm not sure this is how you do thing.

@wash2
Copy link
Contributor

wash2 commented Dec 4, 2023

I cherry picked 86ede0f for #228 which will probably be merged soon

@mmstick mmstick closed this Dec 4, 2023
@wiiznokes wiiznokes deleted the flags-not-clone branch January 4, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmstick mmstick mmstick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wiiznokes @wash2 @mmstick