Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make the single-instance feature additive #219

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

wash2
Copy link
Contributor

@wash2 wash2 commented Nov 21, 2023

This is a refactor of the single instance / dbus activation implementation that makes the feature purely additive. It does add a generic parameter to Core, but I'm not sure of a better way of requiring it in run_single_instance while keeping single-instance feature additive.

@wash2
Copy link
Contributor Author

wash2 commented Nov 21, 2023

pop-os/cosmic-settings#102 has the updates for the settings app.

@wash2 wash2 requested a review from a team November 21, 2023 18:19
@mmstick
Copy link
Member

mmstick commented Nov 21, 2023

Would it be possible to add a DbusActivation variant to app::cosmic::Message for this? Then we could add a dbus_activation method to app::Application for handling it.

@wash2
Copy link
Contributor Author

wash2 commented Nov 21, 2023

Would it be possible to add a DbusActivation variant to app::cosmic::Message for this? Then we could add a dbus_activation method to app::Application for handling it.

Thanks, that would work well

@wash2 wash2 force-pushed the refactor-single-instance branch from 1172d86 to 2de67ad Compare November 21, 2023 20:07
@wash2 wash2 force-pushed the refactor-single-instance branch from 2de67ad to 4b49d2d Compare November 21, 2023 20:18
@mmstick mmstick merged commit 57f4abb into master Nov 21, 2023
9 checks passed
@mmstick mmstick deleted the refactor-single-instance branch November 21, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants