Fix footer corner radius #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-f0x
force-pushed
the
master
branch
4 times, most recently
from
5e01817 to
b42aab9
Compare
wash2
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the primary container style use
radius_s, instead ofradius_xs, which matches the radius of the footer to the designs.Also fixes the vertical padding of the
context_drawerfooter.Since other container styles also used
radius_xs, I also changed them for consistency.Testing with
cosmic-files, I didn't notice anything unusual from this change, but not sure if this should be done, or if the footer should use a custom style (though there isn't aCustomLayer enum).