Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add custom decoding support for EIP712 transactions in TxEnvelope #49

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

Jrigada
Copy link
Contributor

@Jrigada Jrigada commented Feb 11, 2025

Adds custom decoding for EIP712 transactions in TxEnvelope. When the transaction type matches TxType::Eip712, the typed_decode method uses TxEip712::decode_signed_fields to decode the transaction.
All other transaction types continue to use the existing native decoding logic.

@Jrigada Jrigada requested a review from popzxc as a code owner February 11, 2025 13:31
@Jrigada Jrigada changed the title Add custom decoding support for EIP712 transactions in TxEnvelope feat: Add custom decoding support for EIP712 transactions in TxEnvelope Feb 11, 2025
Copy link
Collaborator

@dutterbutter dutterbutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@popzxc popzxc merged commit 3cc8a74 into popzxc:main Feb 12, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants