Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 966 #979

Merged
merged 2 commits into from
Jan 24, 2020
Merged

Issue 966 #979

merged 2 commits into from
Jan 24, 2020

Conversation

HTShin
Copy link
Contributor

@HTShin HTShin commented Dec 11, 2019

jQuery Validation Engine PR Request Template

Please note: Has this feature already been added? Sometimes, duplicate pull requests happen. It's worth checking the pull requests and issue page to see if the change you are requesting has already been made.

Descriptive name.

Fixed issue (hide) hiding all error prompts?! (#966 ).

Type of Change was Made?

What type of change does your code introduce? After creating the PR, tick the checkboxes that apply.

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Improvement (Enhance an existing functionality)
  • Breaking change (fix or feature that would change existing functionality)

Description of the Change Being Made.

Change file:
js/jquery.validationEngine.js

Issue Number

This refers to issue #966
Please give me feedback ^^

Potential Performance Issues

Does the PR have a potential impact on performance on the codebase? If so, to what degree and why does the PR warrant the performance hit?

Tests/Checks

What tests were conducted to ensure the PR functions have no impact on previous functionalities of the code base?

New Dependencies

Have new dependencies been introduced? Please list them with links to documentation and add installation steps to the README.

@dennybrandes dennybrandes merged commit e2eb6d2 into posabsolute:master Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants