Skip to content

Commit

Permalink
Build for ARM Windows (#205)
Browse files Browse the repository at this point in the history
* Build for ARM Windows

* Remove ureq dependency in xtask to get rid of ring dependency

Which causes cross compilation on ARM Windows issues right now

* Tell dist to only manage `crates/air`

So it hopefully doesn't try and compile every crate in our workspace, including heavier dev crates

* Use `precise-builds`

* Revert "Remove ureq dependency in xtask to get rid of ring dependency"

This reverts commit 5549634.

* Add CHANGELOG bullets
  • Loading branch information
DavisVaughan authored Jan 29, 2025
1 parent f93e1ef commit 0661d00
Show file tree
Hide file tree
Showing 4 changed files with 26 additions and 14 deletions.
22 changes: 11 additions & 11 deletions .github/workflows/release-vscode.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ jobs:
- os: windows-latest
target: x86_64-pc-windows-msvc
code-target: win32-x64
# - os: windows-latest
# target: aarch64-pc-windows-msvc
# code-target: win32-arm64
- os: windows-latest
target: aarch64-pc-windows-msvc
code-target: win32-arm64
# - os: ubuntu-20.04
# target: x86_64-unknown-linux-gnu
# code-target: linux-x64
Expand Down Expand Up @@ -126,10 +126,10 @@ jobs:
with:
name: dist-x86_64-pc-windows-msvc
path: dist
# - uses: actions/download-artifact@v4
# with:
# name: dist-aarch64-pc-windows-msvc
# path: dist
- uses: actions/download-artifact@v4
with:
name: dist-aarch64-pc-windows-msvc
path: dist
- run: ls -al ./dist

# Publish to the Code Marketplace.
Expand Down Expand Up @@ -169,10 +169,10 @@ jobs:
with:
name: dist-x86_64-pc-windows-msvc
path: dist
# - uses: actions/download-artifact@v4
# with:
# name: dist-aarch64-pc-windows-msvc
# path: dist
- uses: actions/download-artifact@v4
with:
name: dist-aarch64-pc-windows-msvc
path: dist
- run: ls -al ./dist

# Publish to OpenVSX.
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

# Development version

- ARM Windows binaries are now available (#170).

# 0.2.0

- Initial public release, yay!
Expand Down
14 changes: 11 additions & 3 deletions dist-workspace.toml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[workspace]
members = ["cargo:."]
members = ["cargo:crates/air"]

# Config for 'dist'
[dist]
Expand All @@ -17,11 +17,19 @@ windows-archive = ".zip"
unix-archive = ".tar.gz"
# Target platforms to build apps for (Rust target-triple syntax)
targets = [
"aarch64-apple-darwin",
# Mac
"x86_64-apple-darwin",
"x86_64-unknown-linux-gnu",
"aarch64-apple-darwin",
# Windows
"x86_64-pc-windows-msvc",
"aarch64-pc-windows-msvc",
# Linux
"x86_64-unknown-linux-gnu",
]
# Tell dist to only build `crates/air` rather than every crate in the workspace,
# which it does by default to be conservative but would include some heavier test-only
# crates that aren't required (including xtask).
precise-builds = true
# Whether to auto-include files like READMEs, LICENSEs, and CHANGELOGs (default true)
auto-includes = false
# Which actions to run on pull requests (use "upload" to force a build in CI for testing)
Expand Down
2 changes: 2 additions & 0 deletions editors/code/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@

## Development version

- The extension is now available on ARM Windows (#170).

- The extension now works properly for Intel macOS (#194).

## 0.2.0
Expand Down

0 comments on commit 0661d00

Please sign in to comment.