-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(uv): Lean on uv
for all tasks within Makefile
#316
Conversation
* Be sure to require that UV exists so that all commands work from a fresh checkout * If `.venv` does not exist, create it when checking for UV
uv
for all tasks within Makefile
Conflict with quartodoc is exposed by `uv`
bc3356e
to
81c7bc0
Compare
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! We'll need to adjust to continue supporting Python 3.8, but otherwise this looks great. It's wild how many new features uv
has introduced since we originally migrated to it in August.
Also, you can remove the '!' from the conventional commit title. The '!' is only necessary for breaking changes affecting package consumers (e.g., a change requiring a major version bump). "build(uv): lean on |
uv
for all tasks within Makefileuv
for all tasks within Makefile
Co-authored-by: Taylor Steinberg <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌🏻
I have one outstanding question regarding the integration tests, but regardless, this is awesome! I love the pragmatic use of uv
in different places. It really shows the power of the tooling.
Changes
Breaking changes:Drop python 3.8 supportMain motivation: uv doesn't like to run quartodoc when python 3.8 is supported. However, python 3.8 is EOL, so it is fair to drop support.UV:
.venv
uv
for as many commands as possiblemake
command should be able to be run without requiring to activate the virtual environmentuv
before a python package command is runmake deps
and fold functionality intomake dev
pip
to determine who groups are installed beforeuv
implements group installation: uv pip install --group astral-sh/uv#8590 (comment) . However,uv
is fast that groups are not really needed for now.GHA:
astral-sh/setup-uv
anduv python install VERSION
to installuv
andpython
env: { UV_SYSTEM_PYTHON: true }
uv
is fast to install everything and nothing can get poisoned from prior runs. (Major pain to discover / debug)