Skip to content

Commit

Permalink
Migrate Positron ESLint configuration from .eslintrc.json to eslint.c…
Browse files Browse the repository at this point in the history
…onfig.js (#6172)

As part of merging 1.96 from upstream, ESLint was switched to use flat
config (see: `"eslint.useFlatConfig": true` in `.vscode/settings.json`).
As a result, React linting from `eslint-plugin-react` and
`eslint-plugin-react-hooks` were no longer configured for Positron.

This PR migrates Positron-specific ESLint configuration settings from
`.eslintrc.json` to `eslint.config.js`, thus reestablishing React
linting (most importantly, rules for `react-hooks/rules-of-hooks` and
`react-hooks/exhaustive-deps`).

So, you will now be informed when your React hooks are missing
dependencies again:

<img width="1009" alt="Pasted Graphic"
src="https://github.com/user-attachments/assets/b0ffc323-9725-4ee3-a890-05e6710b353a"
/>
  • Loading branch information
softwarenerd authored Jan 31, 2025
1 parent ec85373 commit 573a321
Show file tree
Hide file tree
Showing 4 changed files with 730 additions and 1,514 deletions.
Loading

0 comments on commit 573a321

Please sign in to comment.