Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new positron.executeHelpTopicProvider API command #5292

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

juliasilge
Copy link
Contributor

@juliasilge juliasilge commented Nov 6, 2024

Addresses #4097

Goes together with quarto-dev/quarto#599; the Quarto PR is needed to actually see this work but this PR should be able to be merged on its own.

QA Notes

In a Quarto file, you should be able to use F1 to bring up help for R like so:

help-quarto

This is only working right now for R, because of #5290. When we fix that, we should also confirm it works in a .qmd as well.

@juliasilge juliasilge requested a review from jmcphers November 7, 2024 03:10
@juliasilge juliasilge marked this pull request as ready for review November 7, 2024 03:10
Copy link
Collaborator

@jmcphers jmcphers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@juliasilge juliasilge merged commit d599f95 into main Nov 7, 2024
3 checks passed
@juliasilge juliasilge deleted the help-topic-provider-language branch November 7, 2024 22:22
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants