Pre package extensions and install them on startup for users #6403
+640
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 |
melissa-barca
commented
Feb 19, 2025
timtmok
reviewed
Feb 19, 2025
src/vs/platform/extensionManagement/node/positronBootstrapExtensionsInitializer.ts
Show resolved
Hide resolved
melissa-barca
force-pushed
the
bootstrap-extensions
branch
2 times, most recently
from
d092f62 to
2b30e74
Compare
defaultExtensionsInitializer so it can be applied in server and desktop
melissa-barca
force-pushed
the
bootstrap-extensions
branch
from
42b71a0 to
0ca3194
Compare
|
The matplot lib test is failing due to missing 
|
|
@melissa-barca I updated so the web based tests will run on the PR as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #6302, #6301, #6305, #5315
Introduces the concept of "bootstrapped extensions". Bundles the following extensions as VSIX files with Positron:
When a user starts up Positron after first installing it or a version change (upgrade or downgrade), Positron will install the bootstrapped extensions for the users. Users will then be able to manage the extensions (upgrade, downgrade, uninstall, disable) themselves. Positron will always prefer whichever version of the extension in newer (bundled or user). When a user downgrades the extension, Positron will attempt to upgrade to the latest packaged version on the next upgrade, but not next Positron launch.
I changed the approach slightly from my initial spec. The initial spec built on top of the existing defaultExtensionInitializer. This approach is heavily inspired by that class but provides the server and desktop logic in src/vs/platform/extensionManagement/node/positronBootstrapExtensionsInitializer.ts.
Release Notes
New Features
Bug Fixes
QA Notes
@:web