Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support deleting console sessions #6436

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

samclark2015
Copy link
Contributor

@samclark2015 samclark2015 commented Feb 21, 2025

Updates console & runtime infrastructure to add calls/events to enable deletion of sessions. Adds "Trash" button on console session tabs to invoke action.

Screen.Recording.2025-02-21.at.3.28.34.PM.mov

Todo:

  • Identify other locations where console sessions are held in state (where do we need to listen for deletion events?)
  • Ensure resources are cleaned up effectively (Positron, ExtHost, extensions) so we don't leak memory

Addresses #6311

Release Notes

New Features

  • Updates RuntimeSessionService to add API to delete runtime sessions by session ID, and adds event to listen for deleted sessions
  • Updates PositronConsoleService to add events when Console sessions are deleted
  • Updates PositronConsoleState to listen for deletion events, and modify state to reflect deleted runtimes/sessions
  • Updates Console session tabs to add delete button visible on hover

Bug Fixes

  • N/A

QA Notes

e2e: @:console

@samclark2015 samclark2015 self-assigned this Feb 21, 2025
Copy link

github-actions bot commented Feb 21, 2025

E2E Tests 🚀
This PR will run tests tagged with: @:critical @:console

readme  valid tags

@samclark2015 samclark2015 marked this pull request as ready for review February 24, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant