-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add positron.r.customExcludes
setting to exclude R installation paths
#6472
base: main
Are you sure you want to change the base?
Conversation
E2E Tests 🚀 |
@@ -203,6 +203,15 @@ | |||
"default": [], | |||
"markdownDescription": "%r.configuration.customBinaries.markdownDescription%" | |||
}, | |||
"positron.r.customExcludes": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of positron.r.interpreters.exclude
, which would be more consistent with the python settings, I opted for more alignment with the existing R settings positron.r.customRootFolders
and positron.r.customBinaries
. However, I'm not sure if positron.r.customExcludes
is descriptive enough.
There will be another setting to override the list of interpreters (#6206)...similarly positron.r.customOverrides
doesn't feel descriptive enough.
If anyone has opinions about this, happy to change the setting name!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer keeping the naming in line with python, "custom" seems to imply the presence of standard excludes which doesn't really make sense?
@@ -203,6 +203,15 @@ | |||
"default": [], | |||
"markdownDescription": "%r.configuration.customBinaries.markdownDescription%" | |||
}, | |||
"positron.r.customExcludes": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer keeping the naming in line with python, "custom" seems to imply the presence of standard excludes which doesn't really make sense?
/** | ||
* Adapted from the function of the same name in extensions/positron-python/src/client/pythonEnvironments/common/externalDependencies.ts. | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be worth making a similar comment in the python file so that if someone has to change something there, they consider changing it here as well.
Summary
positron.r.customExcludes
which allows the user to specify R installation binary paths or directories containing R installations that should be excluded from the UI in PositronSettings UI
Settings JSON
R Language Pack Output
Release Notes
New Features
Bug Fixes
QA Notes
positron.r.customBinaries
andpositron.r.customRootFolders
settings which allow "includes" to be specifiedpositron.r.customExcludes
will take precedence over includes withpositron.r.customBinaries
orpositron.r.customRootFolders