Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fire onDidClose event from PositronDataExplorerInstance when it is disposed #6481

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Fire onDidClose event from PositronDataExplorerInstance when it is disposed #6481

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70015fb
Fire onDidClose event from PositronDataExplorerInstance when it is di…
softwarenerd Feb 25, 2025
de2915e
Fix copyright date
softwarenerd Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions src/vs/workbench/services/positronDataExplorer/browser/positronDataExplorerInstance.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*---------------------------------------------------------------------------------------------
* Copyright (C) 2023-2024 Posit Software, PBC. All rights reserved.
* Copyright (C) 2023-2025 Posit Software, PBC. All rights reserved.
* Licensed under the Elastic License 2.0. See LICENSE.txt for license information.
*--------------------------------------------------------------------------------------------*/

Expand Down Expand Up @@ -114,7 +114,7 @@ export class PositronDataExplorerInstance extends Disposable implements IPositro

//#endregion Private Properties

//#region Constructor
//#region Constructor & Dispose

/**
* Constructor.
Expand Down Expand Up @@ -199,7 +199,18 @@ export class PositronDataExplorerInstance extends Disposable implements IPositro
}));
}

//#endregion Constructor
/**
* Dispose method.
*/
public override dispose(): void {
// Fire the onDidClose event.
this._onDidCloseEmitter.fire();

// Call the base class's dispose method.
super.dispose();
}

//#endregion Constructor & Dispose

//#region IPositronDataExplorerInstance Implementation

Expand Down
Loading