Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New plugin options argument, and other fixes #150

Closed
wants to merge 1 commit into from

Conversation

ZeeCoder
Copy link
Contributor

All the changes:

  • Removed deprecated usages of new Buffer()
  • Accepts a new third pluginOptions parameter with handleResult, which
    allows us to handle the results from PostCSS. (For example: handling messages
    from PostCSS plugins, which was not possible before.)
  • Declared the supported node version in package.json

@ZeeCoder
Copy link
Contributor Author

Note that sourcemap test fails in master as well. 🤷‍♂️

@ZeeCoder
Copy link
Contributor Author

Any chance this could get looked at?
cc @ai @w0rm

@ai
Copy link
Member

ai commented Jan 31, 2019

.idea should be in your local git ignore, not in global

@ai
Copy link
Member

ai commented Jan 31, 2019

I can move and release it (if I have a rights) if CI will be fixed

@ZeeCoder
Copy link
Contributor Author

I might need help on that, as I said it's not my changes that break the CI, it's failing in the current master too.

  * Removed deprecated usages of `new Buffer()`
  * Accepts a new third `pluginOptions` parameter with `handleResult`, which
    allows us to handle the results from PostCSS. (For example: handling messages
    from PostCSS plugins.)
  * Declared the supported node version in package.json
@ai
Copy link
Member

ai commented Jan 31, 2019

Sorry, you need to wait for @w0rm. I am very bad at Gul plugins.

@w0rm
Copy link
Member

w0rm commented Feb 1, 2019

@ZeeCoder can you open an issue that explains your specific use case? An API that allows to pass a callback that can modify postcss result seems a bit hacky to me:

  1. I'd rather not have any configuration that is not a part of https://www.npmjs.com/package/postcss-load-config
  2. what you try to address seems to be a shortcoming of gulp, where the only output is a vinyl file. A stream of files that uses side effects to extract additional stuff feels a bit wrong.

As for buffer.from, could you please open a separate PR for it?

Let's not modify the changelog, it should be done only when a new version is published.

This was referenced Feb 9, 2019
@ZeeCoder
Copy link
Contributor Author

ZeeCoder commented Feb 9, 2019

Closed in favour of #151 and #152

@ZeeCoder ZeeCoder closed this Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants