Skip to content

Commit

Permalink
Update pg_pathman due to vanilla PostgreSQL.
Browse files Browse the repository at this point in the history
1. Fix regression output due to fd0398fcb099.
    Changed tests: pathman_only and pathman_rowmarks.
2. Fix code due to commit d20d8fbd3e4d.
3. Fix comments in test files due to alternate outputs.
  • Loading branch information
Ekaterina Sokolova committed Jul 1, 2024
1 parent 92b69d8 commit afbec7f
Show file tree
Hide file tree
Showing 14 changed files with 939 additions and 46 deletions.
26 changes: 22 additions & 4 deletions expected/pathman_only.out
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,31 @@
* NOTE: This test behaves differenly on PgPro
* ---------------------------------------------
*
* Since 12 (608b167f9f), CTEs which are scanned once are no longer an
* optimization fence, which changes practically all plans here. There is
* --------------------
* pathman_only_1.sql
* --------------------
* Since 608b167f9f in PostgreSQL 12, CTEs which are scanned once are no longer
* an optimization fence, which changes practically all plans here. There is
* an option to forcibly make them MATERIALIZED, but we also need to run tests
* on older versions, so create pathman_only_1.out instead.
*
* Since 55a1954da16 and 6ef77cf46e8 (>= 13) output of EXPLAIN was changed,
* now it includes aliases for inherited tables.
* --------------------
* pathman_only_2.sql
* --------------------
* Since 55a1954da16 and 6ef77cf46e8 in PostgreSQL 13, output of EXPLAIN was
* changed, now it includes aliases for inherited tables.
*
* --------------------
* pathman_only_3.sql
* --------------------
* Since a5fc46414de in PostgreSQL 16, the order of the operands was changed,
* which affected the output of the "Prune by" in EXPLAIN.
*
* --------------------
* pathman_only_4.sql
* --------------------
* Since fd0398fcb09 in PostgreSQL 17, output of EXPLAIN was
* changed, now it displays SubPlan nodes and output parameters.
*/
\set VERBOSITY terse
SET search_path = 'public';
Expand Down
26 changes: 22 additions & 4 deletions expected/pathman_only_1.out
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,31 @@
* NOTE: This test behaves differenly on PgPro
* ---------------------------------------------
*
* Since 12 (608b167f9f), CTEs which are scanned once are no longer an
* optimization fence, which changes practically all plans here. There is
* --------------------
* pathman_only_1.sql
* --------------------
* Since 608b167f9f in PostgreSQL 12, CTEs which are scanned once are no longer
* an optimization fence, which changes practically all plans here. There is
* an option to forcibly make them MATERIALIZED, but we also need to run tests
* on older versions, so create pathman_only_1.out instead.
*
* Since 55a1954da16 and 6ef77cf46e8 (>= 13) output of EXPLAIN was changed,
* now it includes aliases for inherited tables.
* --------------------
* pathman_only_2.sql
* --------------------
* Since 55a1954da16 and 6ef77cf46e8 in PostgreSQL 13, output of EXPLAIN was
* changed, now it includes aliases for inherited tables.
*
* --------------------
* pathman_only_3.sql
* --------------------
* Since a5fc46414de in PostgreSQL 16, the order of the operands was changed,
* which affected the output of the "Prune by" in EXPLAIN.
*
* --------------------
* pathman_only_4.sql
* --------------------
* Since fd0398fcb09 in PostgreSQL 17, output of EXPLAIN was
* changed, now it displays SubPlan nodes and output parameters.
*/
\set VERBOSITY terse
SET search_path = 'public';
Expand Down
26 changes: 22 additions & 4 deletions expected/pathman_only_2.out
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,31 @@
* NOTE: This test behaves differenly on PgPro
* ---------------------------------------------
*
* Since 12 (608b167f9f), CTEs which are scanned once are no longer an
* optimization fence, which changes practically all plans here. There is
* --------------------
* pathman_only_1.sql
* --------------------
* Since 608b167f9f in PostgreSQL 12, CTEs which are scanned once are no longer
* an optimization fence, which changes practically all plans here. There is
* an option to forcibly make them MATERIALIZED, but we also need to run tests
* on older versions, so create pathman_only_1.out instead.
*
* Since 55a1954da16 and 6ef77cf46e8 (>= 13) output of EXPLAIN was changed,
* now it includes aliases for inherited tables.
* --------------------
* pathman_only_2.sql
* --------------------
* Since 55a1954da16 and 6ef77cf46e8 in PostgreSQL 13, output of EXPLAIN was
* changed, now it includes aliases for inherited tables.
*
* --------------------
* pathman_only_3.sql
* --------------------
* Since a5fc46414de in PostgreSQL 16, the order of the operands was changed,
* which affected the output of the "Prune by" in EXPLAIN.
*
* --------------------
* pathman_only_4.sql
* --------------------
* Since fd0398fcb09 in PostgreSQL 17, output of EXPLAIN was
* changed, now it displays SubPlan nodes and output parameters.
*/
\set VERBOSITY terse
SET search_path = 'public';
Expand Down
26 changes: 22 additions & 4 deletions expected/pathman_only_3.out
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,31 @@
* NOTE: This test behaves differenly on PgPro
* ---------------------------------------------
*
* Since 12 (608b167f9f), CTEs which are scanned once are no longer an
* optimization fence, which changes practically all plans here. There is
* --------------------
* pathman_only_1.sql
* --------------------
* Since 608b167f9f in PostgreSQL 12, CTEs which are scanned once are no longer
* an optimization fence, which changes practically all plans here. There is
* an option to forcibly make them MATERIALIZED, but we also need to run tests
* on older versions, so create pathman_only_1.out instead.
*
* Since 55a1954da16 and 6ef77cf46e8 (>= 13) output of EXPLAIN was changed,
* now it includes aliases for inherited tables.
* --------------------
* pathman_only_2.sql
* --------------------
* Since 55a1954da16 and 6ef77cf46e8 in PostgreSQL 13, output of EXPLAIN was
* changed, now it includes aliases for inherited tables.
*
* --------------------
* pathman_only_3.sql
* --------------------
* Since a5fc46414de in PostgreSQL 16, the order of the operands was changed,
* which affected the output of the "Prune by" in EXPLAIN.
*
* --------------------
* pathman_only_4.sql
* --------------------
* Since fd0398fcb09 in PostgreSQL 17, output of EXPLAIN was
* changed, now it displays SubPlan nodes and output parameters.
*/
\set VERBOSITY terse
SET search_path = 'public';
Expand Down
Loading

0 comments on commit afbec7f

Please sign in to comment.