Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Actions pipeline for pgSphere #69

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

borodun
Copy link
Contributor

@borodun borodun commented Sep 26, 2023

Use GitHub Actions for pgSphere pipeline. At this moment, builds with HEALPix are failing due to compilation warning, but #68 should fix this.

Copy link
Contributor

@esabol esabol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it! Fantastic contribution!

@esabol
Copy link
Contributor

esabol commented Sep 26, 2023

I also dream of a GitHub Actions pipeline which, on merges to the master branch, uploads the latest documentation to the GitHub Pages associated with this repository. Could you help with that? That's probably a separate pipeline though.

@esabol
Copy link
Contributor

esabol commented Sep 26, 2023

@borodun: Actually, I think "make test" should come before "make install"?

Also, I am curious as to why you chose fail-fast: false?

@borodun
Copy link
Contributor Author

borodun commented Sep 27, 2023

@esabol, I moved make test before make install. About fail-fast: false: I wanted to make the CI behavior the same as the current Travis pipeline, it will not cancel jobs if other jobs fail first. In my opinion, this will help to get more informative pipeline runs.

@borodun
Copy link
Contributor Author

borodun commented Sep 27, 2023

@esabol, regarding the pipeline for docs: that’s the plan. We need to organize access to GitHub Pages for this repository. This is a more administrative issue. We want to get this done as soon as possible.

@vitcpp vitcpp merged commit dbd564d into postgrespro:master Sep 27, 2023
1 check passed
@esabol
Copy link
Contributor

esabol commented Sep 27, 2023

The new GitHub Actions pipeline doesn't seem to be working in PR #65, unfortunately. Very weird error that I've not encountered before in my GitHub Actions.

@vitcpp
Copy link
Contributor

vitcpp commented Sep 27, 2023

@esabol, @borodun It seems the problem is in line 63 of build-and-check.yml: github.ref_name is 65/merge. It seems the / symbol should be replaced with some other acceptable symbol or another var should be used.

@esabol
Copy link
Contributor

esabol commented Sep 27, 2023

Changing the '/' to a '-' in $github_ref_name can be done as shown here:

https://github.com/mbiagetti/github-action-poc/pull/2/files

But that method seems very convoluted and annoying. Would this method work?

https://stackoverflow.com/a/67290085/5153779

@borodun
Copy link
Contributor Author

borodun commented Sep 28, 2023

We can use something like https://github.com/marketplace/actions/github-slug-action to create slugged versions of variables. We can add:

- name: Inject slug/short variables
  uses: rlespinasse/github-slug-action@v4

And change ${{ github.ref_name }} to ${{ env.GITHUB_REF_SLUG_URL }}

I'll create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants