make test: Don't track NOTICEs #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esabol
approved these changes
Oct 5, 2023
|
Cool. Thank you! |
vitcpp
approved these changes
Oct 5, 2023
There's little value in tracking the noise of NOTICEs emitted during loading pg_sphere.test.sql, so just mute them. The gain from this change is that future patches will not have to update the changed line numbers in the output tracked. (Cf. c2a2351)
|
Rebased to master. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's little value in tracking the noise of NOTICEs emitted during loading pg_sphere.test.sql, so just mute them.
The gain from this change is that future patches will not have to update the changed line numbers in the output tracked. (Cf. c2a2351)
\set ECHO allat the end of the file can be removed since a new psql session will be created for the next file anyway.