Selectivity estimators for <@(spoint, scircle) and spoint_dwithin(spoint, spoint, float8) #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is an awesome contribution! Thank you! |
esabol
reviewed
Oct 6, 2023
|
Am 6. Oktober 2023 21:41:54 MESZ schrieb Ed Sabol ***@***.***>:
@esabol commented on this pull request.
> @@ -241,8 +248,11 @@ pg_sphere--1.2.3--1.3.0.sql: pgs_brin.sql.in
pg_sphere--1.3.0--1.3.1.sql:
cat ***@***.*** > $@
-pg_sphere--1.3.1--1.3.2.sql:
- cat ***@***.*** > $@
+ifeq ($(has_support_functions),y)
+pg_sphere--1.3.1--1.3.2.sql: pgs_gist_support.sql.in
+endif
+pg_sphere--1.3.1--1.3.2.sql: pgs_circle_sel.sql.in
+ cat ***@***.*** $^ > $@
I'm not sure, but I wonder if lines 251-255 should be the following instead?
```
ifeq ($(has_support_functions),y)
pg_sphere--1.3.1--1.3.2.sql: pgs_gist_support.sql.in pgs_circle_sel.sql.in
else
pg_sphere--1.3.1--1.3.2.sql: pgs_circle_sel.sql.in
endif
cat ***@***.*** $^ > $@
```
--
Reply to this email directly or view it on GitHub:
#80 (review)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
It does works that way, $^ collects all dependencies.
|
esabol
approved these changes
Oct 12, 2023
esabol
suggested changes
Oct 12, 2023
vitcpp
reviewed
Oct 12, 2023
src/point.c
Outdated
| float8 within = PG_GETARG_FLOAT8(2); | ||
| float8 dist = spoint_dist(p1, p2); | ||
|
|
||
| PG_RETURN_BOOL(dist <= within); |
There was a problem hiding this comment.
I guess, FPle should be used instead of direct comparison. pgSphere calculations are executed with EPSILON = 1E-9. When we compare two distances, all the numbers less than 1E-9 should be treated as zeroes, I think. There is the example: spoint_in_circle() function, where FPle is used. I would also propose to add some tests for this function, if it can be done.
There was a problem hiding this comment.
Ack, will change that (likely later, not now).
There was a problem hiding this comment.
Implemented in 89dc41d.
esabol
reviewed
Oct 14, 2023
Alena0704
reviewed
Oct 16, 2023
esabol
approved these changes
Oct 16, 2023
esabol
suggested changes
Oct 16, 2023
esabol
approved these changes
Oct 18, 2023
|
In case anyone is interested in comparing selectivity estimators, similar efforts are in progress over in the q3c repo as well: |
|
Rebased. |
vitcpp
requested changes
Oct 19, 2023
This implements restriction selectivity estimation for the <@ @> !<@ !@> family of operators on spoint and scircle. The selectivity is estimated to be (area of sphere circle) / (4 pi). Queries like `select * from sky where sky.star <@ scircle(const, radius)` will be able to properly estimate if using an index is appropriate depending on the size of radius. Secondly, a function spoint_dwithin(p1 spoint, p2 spoint, radius float8) is added that effectively returns `p1 <-> p2 <= radius`. But other than this two-operator expression, it has GIST index support so the optimizer can rewrite it to either `p1 <@ scircle(p2, radius)` or `p2 <@ scircle(p1, radius)`, i.e. it is symmetric in the first two arguments. This allows efficient matching queries without the user having to encode the join ordering in the query. On PostgreSQL 10/11, the spoint_dwithin function is created, but without the GIST support since that only appeared in PG12. The file expected/selectivity_1.out is used on PG10/11; it has <@ flipped around to @> in some plans.
vitcpp
approved these changes
Oct 19, 2023
Alena0704
approved these changes
Oct 20, 2023
|
@df7cb Thank you for the PR! |
|
@vitcpp @esabol @Alena0704 thanks for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements restriction selectivity estimation for the <@ @> !<@ !@>
family of operators on spoint and scircle. The selectivity is estimated
to be (area of sphere circle) / (4 pi).
Queries like
select * from sky where sky.star <@ scircle(const, radius)will be able to properly estimate if using an index is appropriate
depending on the size of radius.
Secondly, a function spoint_dwithin(p1 spoint, p2 spoint, radius float8)
is added that effectively returns
p1 <-> p2 <= radius. But other thanthis two-operator expression, it has GIST index support so the optimizer
can rewrite it to either
p1 <@ scircle(p2, radius)orp2 <@ scircle(p1, radius), i.e. it is symmetric in the first two arguments.This allows efficient matching queries without the user having to encode
the join ordering in the query.
On PostgreSQL 10/11, the spoint_dwithin function is created, but without
the GIST support since that only appeared in PG12.
The file expected/selectivity_1.out is used on PG10/11; it has <@
flipped around to @> in some plans.