Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable smoc_gin_ops index resolution #86

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

df7cb
Copy link
Contributor

@df7cb df7cb commented Oct 23, 2023

Back when smoc GIN indexes were implemented, indexes did not support opclass options yet; that was added only later in PG 13.

Add an "order" parameter on the smoc_gin_ops opclass to allow picking the smoc index granularity between level 0 and 12. (Larger levels do not fit into the internal int32 datatype anymore.)

Example:
create index on sky using gin (coverage smoc_gin_ops (order = 8))

Copy link
Contributor

@msdemlei msdemlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a useful new feature for me, so +1 on that account. I've lightly reviewed the code and have found no reason to complain (disclaimer: I'm no expert for PG indexing).

@df7cb df7cb force-pushed the smoc_gin_options branch 2 times, most recently from d01bd7d to c72377a Compare October 25, 2023 09:07
Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved
doc/indices.sgm Show resolved Hide resolved
Back when smoc GIN indexes were implemented, indexes did not support
opclass options yet; that was added only later in PG 13.

Add an "order" parameter on the smoc_gin_ops opclass to allow picking
the smoc index granularity between level 0 and 12. (Larger levels do not
fit into the internal int32 datatype anymore.)

Example:
`create index on sky using gin (coverage smoc_gin_ops (order = 8))`
@vitcpp vitcpp merged commit c0777a7 into postgrespro:master Oct 26, 2023
15 checks passed
@df7cb df7cb deleted the smoc_gin_options branch October 26, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants