adjust postlight insights custom selectors #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
johnholdun
approved these changes
Nov 1, 2022
|
What's up with CI on this project? It failed on my last PR too... |
|
(I'm not authorized to merge, BTW.) |
|
Yeah, something went wrong with the CircleCI config. I opened an issue to track it; doesn't seem related to your work specifically. I will merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses this issue by adjusting the selectors in Postlight.com's custom selector. I had to expand the main content's selector and then exclude a few elements from within it. That way the hero image gets pulled in as part of the content and can be displayed by the Reader.
Note that the Parser does successfully select the hero image and emit it to the Reader as the
lead_image_url, but that the Reader does not make use of that field for anything. So there might be a bigger design/product question to explore there. This is a reasonable fix in the meantime.