-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opack: fix byte encoding length #2472
base: master
Are you sure you want to change the base?
Conversation
I'm not sure this is correct, I will have to verify with macOS implementation first. |
Nope, you are correct 👍
Please update the documentation to reflect this as well. |
@postlund, I took a look at the docs, and realized that the same might apply to strings and pointers as well. I think pointers would be hard to test, and I think either way no one will run into a 32 bit or 64 bit pointer... At least strings, though, can you test? |
You are probably right. I'll see if I can try it out. Even if we use a large pointer since, we can still put a small value in the actual payload. So it's not much harder to test than smaller values. |
Any update? |
I'll merge it if you update the documentation related to your changes 👍 |
I was actually wondering if you had been able to test strings or pointers for the similar length behavior. |
Ah, right. I'll see if I can do that. |
So, I used my example from the documentation but added an additional element at the end to ensure the pointer is somewhere inside the payload (I added
The idea is now to change the pointer for the
So I would say current documentation is correct (although, I see now that C2 Is mentioned twice...). It makes sense for pointers as pointers are just indices and not raw byte position in the payload. |
#2403 (comment)