Add InputAction support to Companion Protocol for Hid Commands #2516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@postlund I was able to get set up with gitpod, so everything here has been run through chickn. Thanks for your help with that.
I added handling of double tap and also changed the delay for Hold to a parameter with a default of one second.
I added tests that touch each of the hid commands with each InputAction. I tried to implement similar checks to the ones used in MRP to verify the actions themselves, but I couldn't get the timing check to work for Hold, so it would always clock them as single taps. If you have any advice on how to better handle the tests, or other improvements, let me know.