Added support for usage of --data-binary flag when using long format …

…option for body typr binary
postmanlabs · Sep 30, 2024 · 2ffde7a · 2ffde7a
1 parent 3494492
commit 2ffde7a
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 1 deletion.
diff --git a/codegens/curl/lib/index.js b/codegens/curl/lib/index.js
@@ -201,7 +201,7 @@ self = module.exports = {
             });
             break;
           case 'file':
-            snippet += indent + form('-d', format);
+            snippet += indent + (format ? '--data-binary' : '-d');
             snippet += ` ${quoteType}@${sanitize(body[body.mode].src, trim)}${quoteType}`;
             break;
           default:

diff --git a/codegens/curl/test/unit/convert.test.js b/codegens/curl/test/unit/convert.test.js
@@ -1144,5 +1144,37 @@ describe('curl convert function', function () {
         });
       });
     });
+
+    it('should use --data-binary when request body type is binary', function () {
+      var request = new Request({
+        'method': 'POST',
+        'header': [],
+        'body': {
+          'mode': 'file',
+          'file': {
+            'src': 'file-path/collection123.json'
+          }
+        },
+        'url': {
+          'raw': 'https://postman-echo.com/get',
+          'protocol': 'https',
+          'host': [
+            'postman-echo',
+            'com'
+          ],
+          'path': [
+            'get'
+          ]
+        }
+      });
+
+      convert(request, { longFormat: true }, function (error, snippet) {
+        if (error) {
+          expect.fail(null, null, error);
+        }
+        expect(snippet).to.be.a('string');
+        expect(snippet).to.include('--data-binary \'@file-path/collection123.json\'');
+      });
+    });
   });
 });