Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a debug flag to know what is happening #295

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eloyesp
Copy link

@eloyesp eloyesp commented Mar 8, 2017

As mentioned in #294 it just adds a debug flag to see what commands are being run.

I don't know how to add tests for it :(

@havenwood
Copy link
Collaborator

On the testing front, it doesn't address the feature functionality, but it'd be nice to test the option parsing in test/ruby-install-tests/parse_options_test.sh.

@eloyesp
Copy link
Author

eloyesp commented Jun 27, 2018

@havenwood I did that but it adds a xtrace for shunit with a lot of noise within the tests :)

function test_parse_options_with_debug()
{
       parse_options "--debug" "ruby"

       assertTrue "did not set -x within the script" "[ -o xtrace ]"
}

@havenwood
Copy link
Collaborator

@eloyesp Ahh, good point.

@postmodern
Copy link
Owner

postmodern commented Aug 5, 2018

My only concern is that set -x may be too verbose for most use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants