TypeHelpers: pre-callocate optionNames even if no names are provided #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add documentation as suggested in #377 (comment)? |
This prevents clients from reading junk values, as the optionNames array is also optional. pothosware#377 (comment)
ericek111
force-pushed
the
fix-optionnames
branch
from
20e5c7d to
aa9af5a
Compare
|
Sorry, I didn't give it much thought. I've force-pushed the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SoapySDRArgInfo struct has an optional
optionNamesarray. However, the client has no way of knowing whether these labels were filled by the SDR driver or are left uninitialized. Allocating and zeroing the array is more foolproof, in my opinion, and does not break the ABI.See: #377 (comment)