Add Tag Support #25
Merged
Add Tag Support #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
potibm
reviewed
Apr 20, 2024
|
Wow. Thanks for aligning so much with my strange API :) Btw.. I even could use this feature for my own website... thanks again :) |
Strange or not, it saved me a bunch of time on EchoFeed so I'm very grateful. |
|
@rknightuk phpunit mentions some risky tests... |
potibm
approved these changes
May 23, 2024
| { | ||
| return [ | ||
| '$type' => parent::TYPE . '#tag', | ||
| "tag" => $this->tag, |
There was a problem hiding this comment.
dunno why ECS does not catch those double-quotes here...
There was a problem hiding this comment.
@rknightuk could you take a look at the code style, please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addFacetsFromTagsandaddFacetsFromMentionsAndLinksAndTagsI'm not sure how you want to handle this. Right now I've added new methods as to not break existing installs and keep the existing methods. The cleaner way would be to bump a major version and remove/rename the old
addFacetsFromMentionsAndLinksmethod.Let me know and I'm happy to update if need be.
I have been using my version of this code on EchoFeed and it's been working very well. This is a complete copy of what I have there.