Skip to content

Commit

Permalink
Fix special tests in the new workflow structure (apache#44083)
Browse files Browse the repository at this point in the history 
When apache#43979 there was a typo where inputs passed as test-groups
were not passed to unit tests in "special-tests" case - because
the "needs.build-info.outputs" were used instead.

Unfortunately this is not caught by GitHub parsing the workflows,
it will only signal it by having annotations of errors on the
affected actions - missing needs.build-info entries are simply
replaced by empty string.
  • Loading branch information
@potiuk
potiuk authored Nov 16, 2024
1 parent d8bff00 commit bf124d0
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 13 deletions.
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -501,6 +501,7 @@ jobs:
excluded-providers-as-string: ${{ needs.build-info.outputs.excluded-providers-as-string }}
canary-run: ${{ needs.build-info.outputs.canary-run }}
upgrade-to-newer-dependencies: ${{ needs.build-info.outputs.upgrade-to-newer-dependencies }}
include-success-outputs: ${{ needs.build-info.outputs.include-success-outputs }}
debug-resources: ${{ needs.build-info.outputs.debug-resources }}

tests-integration-system:
Expand Down
30 changes: 17 additions & 13 deletions .github/workflows/special-tests.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,10 @@ on: # yamllint disable-line rule:truthy
description: "Whether to upgrade to newer dependencies or not (true/false)"
required: true
type: string
include-success-outputs:
description: "Whether to include success outputs or not (true/false)"
required: true
type: string
debug-resources:
description: "Whether to debug resources or not (true/false)"
required: true
Expand All @@ -85,7 +89,7 @@ jobs:
downgrade-sqlalchemy: "true"
test-name: "MinSQLAlchemy-Postgres"
test-scope: "DB"
test-groups: ${{ needs.build-info.outputs.test-groups }}
test-groups: ${{ inputs.test-groups }}
backend: "postgres"
image-tag: ${{ inputs.image-tag }}
python-versions: "['${{ inputs.default-python-version }}']"
Expand All @@ -109,7 +113,7 @@ jobs:
upgrade-boto: "true"
test-name: "LatestBoto-Postgres"
test-scope: "All"
test-groups: ${{ needs.build-info.outputs.test-groups }}
test-groups: ${{ inputs.test-groups }}
backend: "postgres"
image-tag: ${{ inputs.image-tag }}
python-versions: "['${{ inputs.default-python-version }}']"
Expand All @@ -118,7 +122,7 @@ jobs:
excludes: "[]"
core-test-types-list-as-string: ${{ inputs.core-test-types-list-as-string }}
providers-test-types-list-as-string: ${{ inputs.providers-test-types-list-as-string }}
include-success-outputs: ${{ needs.build-info.outputs.include-success-outputs }}
include-success-outputs: ${{ inputs.include-success-outputs }}
run-coverage: ${{ inputs.run-coverage }}
debug-resources: ${{ inputs.debug-resources }}

Expand All @@ -134,7 +138,7 @@ jobs:
downgrade-pendulum: "true"
test-name: "Pendulum2-Postgres"
test-scope: "All"
test-groups: ${{ needs.build-info.outputs.test-groups }}
test-groups: ${{ inputs.test-groups }}
backend: "postgres"
image-tag: ${{ inputs.image-tag }}
python-versions: "['${{ inputs.default-python-version }}']"
Expand All @@ -143,7 +147,7 @@ jobs:
excludes: "[]"
core-test-types-list-as-string: ${{ inputs.core-test-types-list-as-string }}
providers-test-types-list-as-string: ${{ inputs.providers-test-types-list-as-string }}
include-success-outputs: ${{ needs.build-info.outputs.include-success-outputs }}
include-success-outputs: ${{ inputs.include-success-outputs }}
run-coverage: ${{ inputs.run-coverage }}
debug-resources: ${{ inputs.debug-resources }}

Expand All @@ -159,7 +163,7 @@ jobs:
enable-aip-44: "false"
test-name: "InProgressDisabled-Postgres"
test-scope: "All"
test-groups: ${{ needs.build-info.outputs.test-groups }}
test-groups: ${{ inputs.test-groups }}
backend: "postgres"
image-tag: ${{ inputs.image-tag }}
python-versions: "['${{ inputs.default-python-version }}']"
Expand All @@ -168,7 +172,7 @@ jobs:
excludes: "[]"
core-test-types-list-as-string: ${{ inputs.core-test-types-list-as-string }}
providers-test-types-list-as-string: ${{ inputs.providers-test-types-list-as-string }}
include-success-outputs: ${{ needs.build-info.outputs.include-success-outputs }}
include-success-outputs: ${{ inputs.include-success-outputs }}
run-coverage: ${{ inputs.run-coverage }}
debug-resources: ${{ inputs.debug-resources }}

Expand All @@ -183,7 +187,7 @@ jobs:
runs-on-as-json-default: ${{ inputs.runs-on-as-json-default }}
test-name: "Postgres"
test-scope: "Quarantined"
test-groups: ${{ needs.build-info.outputs.test-groups }}
test-groups: ${{ inputs.test-groups }}
backend: "postgres"
image-tag: ${{ inputs.image-tag }}
python-versions: "['${{ inputs.default-python-version }}']"
Expand All @@ -192,7 +196,7 @@ jobs:
excludes: "[]"
core-test-types-list-as-string: ${{ inputs.core-test-types-list-as-string }}
providers-test-types-list-as-string: ${{ inputs.providers-test-types-list-as-string }}
include-success-outputs: ${{ needs.build-info.outputs.include-success-outputs }}
include-success-outputs: ${{ inputs.include-success-outputs }}
run-coverage: ${{ inputs.run-coverage }}
debug-resources: ${{ inputs.debug-resources }}

Expand All @@ -207,7 +211,7 @@ jobs:
runs-on-as-json-default: ${{ inputs.runs-on-as-json-default }}
test-name: "Postgres"
test-scope: "ARM collection"
test-groups: ${{ needs.build-info.outputs.test-groups }}
test-groups: ${{ inputs.test-groups }}
backend: "postgres"
image-tag: ${{ inputs.image-tag }}
python-versions: "['${{ inputs.default-python-version }}']"
Expand All @@ -216,7 +220,7 @@ jobs:
excludes: "[]"
core-test-types-list-as-string: ${{ inputs.core-test-types-list-as-string }}
providers-test-types-list-as-string: ${{ inputs.providers-test-types-list-as-string }}
include-success-outputs: ${{ needs.build-info.outputs.include-success-outputs }}
include-success-outputs: ${{ inputs.include-success-outputs }}
run-coverage: ${{ inputs.run-coverage }}
debug-resources: ${{ inputs.debug-resources }}

Expand All @@ -231,7 +235,7 @@ jobs:
runs-on-as-json-default: ${{ inputs.runs-on-as-json-default }}
test-name: "SystemTest"
test-scope: "System"
test-groups: ${{ needs.build-info.outputs.test-groups }}
test-groups: ${{ inputs.test-groups }}
backend: "postgres"
image-tag: ${{ inputs.image-tag }}
python-versions: "['${{ inputs.default-python-version }}']"
Expand All @@ -240,6 +244,6 @@ jobs:
excludes: "[]"
core-test-types-list-as-string: ${{ inputs.core-test-types-list-as-string }}
providers-test-types-list-as-string: ${{ inputs.providers-test-types-list-as-string }}
include-success-outputs: ${{ needs.build-info.outputs.include-success-outputs }}
include-success-outputs: ${{ inputs.include-success-outputs }}
run-coverage: ${{ inputs.run-coverage }}
debug-resources: ${{ inputs.debug-resources }}

0 comments on commit bf124d0

Please sign in to comment.