fix: Drizzle transactions not using lock context for React-Native #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ext correctly for transactions. Renamed Drizzle source files.
🦋 Changeset detectedLatest commit: f783ecc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
… from PSSqliteSession.
stevensJourney
approved these changes
Jan 16, 2025
rkistner
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of #463 locks were fixed for
React-Native, which resulted in Drizzle transactions on RN projects to never be executed. This was due to the original Drizzle transaction implementation not using the correct lock context. I could confirm that this issue was happening for bothRNQSandOPSqlite, but not for web.Fix
PowerSyncSQLiteSessionhas been broken intoPowerSyncSQLiteSessionandPowerSyncSQLiteBaseSession, which ensures that a transaction uses the constrained LockContext instead of the db context (allowing transactions to be executed in the lock context).This also makes room to eventually implement nested transactions/save points in
PowerSyncSqliteBaseSession.Test
To verify this works across the board, I tested the fix for
RNQS,OPSqlite, and Web.The source files have also been renamed to better match class names.