Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade typescript and target ES version #195

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Upgrade typescript and target ES version #195

merged 2 commits into from
Feb 6, 2025

Conversation

simolus3
Copy link
Contributor

@simolus3 simolus3 commented Feb 5, 2025

I've extracted this into a separate PR to reduce the size of the bucket priorities PR. This changes our packages to target ES2024-compatible runtimes, and also updates TypeScript to 5.7 for ES2024 support.

A change is that Buffer is a generic type in 5.7, that change was added to express the API differences between shared and non-shared array buffers. It looks like we have to consistently use Buffer<ArrayBuffer> instead of the raw Buffer type to avoid compilation errors.

Copy link

changeset-bot bot commented Feb 5, 2025

⚠️ No Changeset found

Latest commit: 78e7087

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

rkistner
rkistner previously approved these changes Feb 5, 2025
@simolus3
Copy link
Contributor Author

simolus3 commented Feb 5, 2025

Do we need a version bump for this?

@rkistner
Copy link
Contributor

rkistner commented Feb 5, 2025

I think a changeset should be done either way, to ensure new versions any changed packages are published in the next release, even though we're not releasing yet. Should probably be a minor version bump for packages depending on the new node version.

@simolus3 simolus3 merged commit 7f9bb19 into main Feb 6, 2025
15 checks passed
@simolus3 simolus3 deleted the feat/es2024 branch February 6, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants