Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve error handling for kotlin errors #20

Merged
merged 2 commits into from
Feb 11, 2025
Merged

chore: improve error handling for kotlin errors #20

merged 2 commits into from
Feb 11, 2025

Conversation

DominicGBauer
Copy link
Contributor

Description

  • Implement the latest powersync-kotlin version
  • Apply changes as functions now throw and therefore need a try
  • Improve __fetchCredentials to log the error but not crash the app

Testing

Ran fetchCredentials error and table update errors in Swift Demo to confirm they no longer crash the app.

This is how handled errors will now display in Swift without the Kotlin unintelligible stack trace.

🔴 PowerSyncException: error while compiling: SELECT * FROM todofail
no such table: todofail

@DominicGBauer DominicGBauer self-assigned this Feb 10, 2025
@DominicGBauer DominicGBauer merged commit 72dd7e1 into main Feb 11, 2025
1 check passed
@DominicGBauer DominicGBauer deleted the chore/improve-error-handling-in-swift branch February 11, 2025 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevensJourney stevensJourney stevensJourney approved these changes

Assignees

@DominicGBauer DominicGBauer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DominicGBauer @stevensJourney