[WIP] Tan phi generator extension #3146
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sophie Frasnedo <[email protected]>
So-Fras
added
October 2024 release
December 2024 release
and removed
October 2024 release
labels
geofjamg
reviewed
Nov 4, 2024
| /** | ||
| * @author Sophie Frasnedo {@literal <sophie.frasnedo at rte-france.com>} | ||
| */ | ||
| public interface GeneratorTanPhi extends Extension<Generator> { |
There was a problem hiding this comment.
@So-Fras are we sure tan phi is the correct and usual word in english ?
There was a problem hiding this comment.
Not at all! I don't like that name either and I hope to find a better alternative.
There was a problem hiding this comment.
CIM defines cim:RegulatingControlModeKind.powerFactor, I would suggest GeneratorPowerFactorRegulation.
but beware that powerFactor is cosPhi, not tanPhi
There was a problem hiding this comment.
So there is no standard term for tanPhi? Any if modelling using cos phi instead of tan phi is the standard way we should also use it, this is equivalent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: