Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SerDe: fix skipping tree node in JSON #3266

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

flo-dup
Copy link
Contributor

@flo-dup flo-dup commented Jan 10, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
No, but PR #3211 introduced a unit test which fails.

What kind of change does this PR introduce?
Bug fix

What is the current behavior?
Call on skipChildNodes on a JSON file while on a node having scalar value attributes leads to an exception

What is the new behavior (if this is a feature change)?
Call on skipChildNodes on a JSON file while on a node having scalar value attributes skip the whole current node. Hence skipChildNodes has been renamed into skipNode.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

@flo-dup flo-dup requested review from olperr1 and geofjamg January 10, 2025 14:22
Signed-off-by: Olivier Perrin <[email protected]>
@olperr1 olperr1 marked this pull request as ready for review February 11, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants