Formatter for printing ReportNode #3317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
|
To me this is not a breaking change. Interface |
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
geofjamg
reviewed
Feb 10, 2025
| * @author Florian Dupuy {@literal <florian.dupuy at rte-france.com>} | ||
| */ | ||
| @FunctionalInterface | ||
| public interface Formatter { |
There was a problem hiding this comment.
Maybe we can name it ReportFormatter or MessageFormatter to avoid confusion with technical / JDK formatting classes ?
Signed-off-by: Florian Dupuy <[email protected]>
|
geofjamg
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Feature
What is the current behavior?
There's no way to do any formatting when printing a ReportNode or getting a message of a ReportNode
What is the new behavior (if this is a feature change)?
ReportNode::printtakes aFormatteras argumentReportNode::getMessagetakes aFormatteras argumentIf no argument is provided, default formatting is used (
typedValue -> typedValue.getValue().toString())Does this PR introduce a breaking change or deprecate an API?