Add a way to customize node infos from LabelProvider #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 1, 2024 13:21
Signed-off-by: LE SAULNIER Kevin <[email protected]>
Signed-off-by: LE SAULNIER Kevin <[email protected]>
flo-dup
requested changes
Aug 9, 2024
...e-line-diagram/single-line-diagram-core/src/main/java/com/powsybl/sld/svg/LabelProvider.java
Outdated
Show resolved
Hide resolved
...diagram/single-line-diagram-core/src/main/java/com/powsybl/sld/svg/DefaultLabelProvider.java
Outdated
Show resolved
Hide resolved
...e-line-diagram/single-line-diagram-core/src/main/java/com/powsybl/sld/svg/LabelProvider.java
Outdated
Show resolved
Hide resolved
added 3 commits
August 12, 2024 11:01
Signed-off-by: LE SAULNIER Kevin <[email protected]>
Signed-off-by: LE SAULNIER Kevin <[email protected]>
So-Fras
requested changes
Sep 9, 2024
single-line-diagram/single-line-diagram-core/src/main/java/com/powsybl/sld/svg/NodeInfo.java
Outdated
Show resolved
Hide resolved
...ine-diagram/single-line-diagram-core/src/main/java/com/powsybl/sld/svg/DefaultSVGWriter.java
Show resolved
Hide resolved
...ine-diagram/single-line-diagram-core/src/main/java/com/powsybl/sld/svg/DefaultSVGWriter.java
Outdated
Show resolved
Hide resolved
...ine-diagram/single-line-diagram-core/src/main/java/com/powsybl/sld/svg/DefaultSVGWriter.java
Outdated
Show resolved
Hide resolved
added 2 commits
September 11, 2024 09:29
Signed-off-by: LE SAULNIER Kevin <[email protected]>
…powsybl-diagram into labelprovider-nodeinfos
added 2 commits
September 17, 2024 10:32
flo-dup
requested changes
Sep 23, 2024
...ine-diagram/single-line-diagram-core/src/main/java/com/powsybl/sld/svg/DefaultSVGWriter.java
Outdated
Show resolved
Hide resolved
...e-line-diagram/single-line-diagram-core/src/main/java/com/powsybl/sld/svg/LabelProvider.java
Outdated
Show resolved
Hide resolved
...e-line-diagram/single-line-diagram-core/src/main/resources/ConvergenceLibrary/components.css
Outdated
Show resolved
Hide resolved
...m/single-line-diagram-core/src/main/java/com/powsybl/sld/svg/styles/StyleClassConstants.java
Outdated
Show resolved
Hide resolved
...ine-diagram/single-line-diagram-core/src/main/java/com/powsybl/sld/svg/DefaultSVGWriter.java
Outdated
Show resolved
Hide resolved
...ine-diagram/single-line-diagram-core/src/main/java/com/powsybl/sld/svg/DefaultSVGWriter.java
Outdated
Show resolved
Hide resolved
added 2 commits
September 27, 2024 15:41
Signed-off-by: LE SAULNIER Kevin <[email protected]>
Signed-off-by: LE SAULNIER Kevin <[email protected]>
flo-dup
reviewed
Oct 8, 2024
...e-line-diagram/single-line-diagram-core/src/main/java/com/powsybl/sld/svg/GraphMetadata.java
Outdated
Show resolved
Hide resolved
|
And you also forgot in previous comment
|
Signed-off-by: LE SAULNIER Kevin <[email protected]>
|
flo-dup
approved these changes
Oct 9, 2024
So-Fras
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Feature
What is the current behavior?
Node legend can not be customized with a custom LabelProvider
What is the new behavior (if this is a feature change)?
Node legend can be customized with a custom LabelProvider
Does this PR introduce a breaking change or deprecate an API?
Classes which customize LabelProvider for node infos labels will need to be fixed to match the method "getElectricalNodesInfos" new signature.
"getElectricalNodesInfos" has also been renamed to "getNodesInfos"