Add new CountryEICode #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Caio Luke <[email protected]>
OpenSuze
requested changes
Oct 14, 2024
glsk/glsk-commons/src/main/java/com/powsybl/glsk/commons/CountryEICode.java
Show resolved
Hide resolved
glsk/glsk-commons/src/main/java/com/powsybl/glsk/commons/CountryEICode.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Thank you for the refactoring !
There was a problem hiding this comment.
Thank you for the test coverage !
|
Thank you for this PR ! |
Signed-off-by: Caio Luke <[email protected]>
OpenSuze
approved these changes
Oct 15, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Feature
What is the current behavior?
Country EIC 10YDE-VE-------2 is missing from the API, even though is a valid one.
Valid EIC are listed here: https://www.entsoe.eu/data/energy-identification-codes-eic/eic-approved-codes/
EIC Type Code: Area Y
EIC Code: 10YDE-VE-------2
What is the new behavior (if this is a feature change)?
Added missing Country EIC, as well as adding tests for some existing Country EICs.
Does this PR introduce a breaking change or deprecate an API?