Allow task interruption in groovy scripts #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…+ tests Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
|
|
5 tasks
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
|
This PR will need a version of powsybl-core with powsybl/powsybl-core#2916 merged |
Signed-off-by: Olivier Perrin <[email protected]>
Signed-off-by: Olivier Perrin <[email protected]>
Signed-off-by: Olivier Perrin <[email protected]>
|
# Conflicts: # pom.xml
|
# Conflicts: # .github/workflows/maven.yml # pom.xml
flo-dup
reviewed
Nov 6, 2024
metrix-integration/src/main/groovy/com/powsybl/metrix/integration/MetrixDslDataLoader.groovy
Show resolved
Hide resolved
…nt with TimeSeriesDslLoader Signed-off-by: Nicolas Rol <[email protected]>
flo-dup
approved these changes
Nov 7, 2024
|
|
rolnico
added a commit
that referenced
this pull request
Nov 7, 2024
* add ThreadInterrupt check in groovy loops and right before execution + tests Signed-off-by: Nicolas Rol <[email protected]> * fix issues Signed-off-by: Nicolas Rol <[email protected]> * fix issues Signed-off-by: Nicolas Rol <[email protected]> * fix checkstyle issues Signed-off-by: Nicolas Rol <[email protected]> * Use Abstract test from powsybl-core Signed-off-by: Nicolas Rol <[email protected]> * modif + test on MetrixDslDataLoader Signed-off-by: Nicolas Rol <[email protected]> * fix issue Signed-off-by: Nicolas Rol <[email protected]> * Adapt to AbstractTaskInterruptionTest changes Signed-off-by: Olivier Perrin <[email protected]> * Temporary build powsybl-core 'nro/groovy_interruption' branch Signed-off-by: Olivier Perrin <[email protected]> * move addCompilationCustomizers to createCompilerConfig to be consistent with TimeSeriesDslLoader Signed-off-by: Nicolas Rol <[email protected]> --------- Signed-off-by: Nicolas Rol <[email protected]> Signed-off-by: Olivier Perrin <[email protected]> Co-authored-by: Olivier Perrin <[email protected]> (cherry picked from commit 3b93069)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Feature
What is the current behavior?
If a task is interrupted by a user, it's handled differently depending on whether the task contains a groovy script evaluation or not:
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?