add regulating terminal for converter station #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David BRAQUART <[email protected]>
Signed-off-by: David BRAQUART <[email protected]>
dbraquart
force-pushed
the
TCK-add-regulating-terminal-for-converter-station
branch
from
fbaa0eb to
81ab1bf
Compare
FranckLecuyer
approved these changes
Jul 16, 2024
pom.xml
Outdated
| @@ -52,7 +52,7 @@ | |||
|
|
|||
| <powsybl-ws-dependencies.version>2.11.0</powsybl-ws-dependencies.version> | |||
| <!-- FIXME: powsybl-network-store modules'version is overloaded in the dependencies section.The overloads and this property below have to be removed at next powsybl-ws-dependencies.version upgrade --> | |||
| <powsybl-network-store.version>1.13.0</powsybl-network-store.version> | |||
| <powsybl-network-store.version>1.14.0-SNAPSHOT</powsybl-network-store.version> | |||
There was a problem hiding this comment.
Wait for next network-store client release before merging this PR (with this new release in pom.xml)
Signed-off-by: David BRAQUART <[email protected]>
…rminal-for-converter-station # Conflicts: # network-store-server/src/main/resources/db/changelog/db.changelog-master.yaml # pom.xml
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
2 TCK tests are KO (commented) because VscConverterStation.setRegulatingTerminal is not implemented. This PR adds persistent implementation for getRegulatingTerminal/setRegulatingTerminal in VscConverterStation.
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: