-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement getV and getAngle for busbarsection [WIP] #217
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: HARPER Jon <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
To investigate further. Immediate problem: usually algorithms (e.g. a loadflow) will use setV and setAngle on the getBusView(), not the getBusBreakerView(). So use getBusBreakerViewer here doesn't work well. Other problems:
|
Maybe we can try the following implementation:
|
We encountered the exception while using network-store implementation for visualizing differences between voltage levels. Without answering the question of "who should carry the voltage information", it seems to me that it would make sense to simply get the voltage value from the bus view. Indeed the voltage on a busbar must be equal to the voltage of the bus it belongs to. |
bfe058b
to
c77963e
Compare
Signed-off-by: HARPER Jon [email protected]
Please check if the PR fulfills these requirements (please use
'[x]'
to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'
and skip the restNO
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
bbs.getV() throws TODO UnsupportedException
What is the new behavior (if this is a feature change)?
bbs.getV() works
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
NO